-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkp/pkp-lib#7165 Issue datePublished can be set when adding an issue #3500
base: main
Are you sure you want to change the base?
Conversation
a90e3f7
to
7c1b8b1
Compare
a0399b8
to
53b9da8
Compare
One test failed, probably would be ok if restarted. |
@NateWr for some reason I remembered that this got merged already a while ago. The tests went through back in December and all the changes should be there. I rebased and started the tests again. |
661d618
to
caa5f85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajnyga Just one or two questions/recommendations..
I am not sure what happened here now. I was pushing the new changes to the pr and when I came here I can see that the pr is closed? @asmecher if I accidentally merged something (can not see in the commit history in OJS that I have) then please reverse that. In the meantime can someone else reopen this pr because I can't? Have not seen anything before with pr's |
I think that If you add some changes to this PR it will enable the "Reopen and comment" for you. I show a notification that "ajnyga added 0 commits", and if you see there are no commits in that PR |
ah ok I see, I had upgraded to PHP 8.3 and it seems that PHP-CS-Fixer does not work with that version and that leads to empty commits, just did not read what the console was telling me :D
|
Some of the tests are failing, but it seems that in a point where my additions should not have an effect? |
pkp/pkp-lib#7165