Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#7165 Issue datePublished can be set when adding an issue #3500

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ajnyga
Copy link
Contributor

@ajnyga ajnyga commented Aug 17, 2022

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2022

CLA assistant check
All committers have signed the CLA.

classes/publication/Repository.php Outdated Show resolved Hide resolved
classes/publication/Repository.php Outdated Show resolved Hide resolved
controllers/grid/issues/form/IssueForm.php Show resolved Hide resolved
@ajnyga
Copy link
Contributor Author

ajnyga commented Dec 16, 2022

One test failed, probably would be ok if restarted.

@ajnyga
Copy link
Contributor Author

ajnyga commented Feb 15, 2023

@NateWr for some reason I remembered that this got merged already a while ago. The tests went through back in December and all the changes should be there. I rebased and started the tests again.

Copy link
Contributor

@defstat defstat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajnyga Just one or two questions/recommendations..

@ajnyga
Copy link
Contributor Author

ajnyga commented May 21, 2024

I am not sure what happened here now. I was pushing the new changes to the pr and when I came here I can see that the pr is closed? @asmecher if I accidentally merged something (can not see in the commit history in OJS that I have) then please reverse that. In the meantime can someone else reopen this pr because I can't?

Have not seen anything before with pr's

@defstat
Copy link
Contributor

defstat commented May 21, 2024

I am not sure what happened here now. I was pushing the new changes to the pr and when I came here I can see that the pr is closed? @asmecher if I accidentally merged something (can not see in the commit history in OJS that I have) then please reverse that. In the meantime can someone else reopen this pr because I can't?

Have not seen anything before with pr's

I think that If you add some changes to this PR it will enable the "Reopen and comment" for you.

I show a notification that "ajnyga added 0 commits", and if you see there are no commits in that PR

@ajnyga
Copy link
Contributor Author

ajnyga commented May 21, 2024

ah ok I see, I had upgraded to PHP 8.3 and it seems that PHP-CS-Fixer does not work with that version and that leads to empty commits, just did not read what the console was telling me :D

PHP needs to be a minimum version of PHP 7.4.0 and maximum version of PHP 8.2.*.
Current PHP version: 8.3.4.
To ignore this requirement please set `PHP_CS_FIXER_IGNORE_ENV`.
If you use PHP version higher than supported, you may experience code modified in a wrong way.
Please report such cases at https://github.com/PHP-CS-Fixer/PHP-CS-Fixer .
husky - pre-commit hook exited with code 1 (error)

@ajnyga ajnyga reopened this May 21, 2024
@ajnyga
Copy link
Contributor Author

ajnyga commented May 21, 2024

Some of the tests are failing, but it seems that in a point where my additions should not have an effect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants